Skip to content

"prod-test" chainspec#4385

Merged
mnaamani merged 7 commits intoJoystream:carthagefrom
mnaamani:production-dev-chain
Nov 3, 2022
Merged

"prod-test" chainspec#4385
mnaamani merged 7 commits intoJoystream:carthagefrom
mnaamani:production-dev-chain

Conversation

@mnaamani
Copy link
Copy Markdown
Member

@mnaamani mnaamani commented Oct 18, 2022 •
edited
Loading

  • Add option to run a local "dev" chain using the production config settings at genesis instead of the test settings.

joystream-node --chain prod-test --alice

Unlike joystream-node --dev you will need to purge-chain between runs or use --temp flag:

joystream-node --chain prod-test --alice --temp

  • Update generate weights script to use this chain config

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 18, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
pioneer-testnet ⬜️ Ignored (Inspect) Nov 2, 2022 at 7:23PM (UTC)

@mnaamani mnaamani mentioned this pull request Oct 18, 2022
Open
@mnaamani mnaamani requested a review from Lezek123 October 18, 2022 11:41
Lezek123
Lezek123 reviewed Oct 18, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lezek123 Lezek123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Some benchmarks were broken by this change so I fixed them in cb9f9b4
  2. I think using prod chain name can be a little confusing, since it's not actually a production chain, it's just a chain with production config for benchmarking purposes

@Lezek123
Copy link
Copy Markdown
Contributor

Lezek123 commented Oct 18, 2022

Unlike joystream-node --dev you will need to purge-chain between runs:
joystream-node purge-chain --chain prod

It's also possible to use --tmp flag when running the chain, in this case the data directory is always cleaned

@mnaamani
Copy link
Copy Markdown
Member Author

mnaamani commented Oct 24, 2022

Unlike joystream-node --dev you will need to purge-chain between runs:
joystream-node purge-chain --chain prod

It's also possible to use --tmp flag when running the chain, in this case the data directory is always cleaned

I'll have to test if the --tmp flag also works when using the "benchmark" command.

@mnaamani mnaamani changed the title prod chainspec "bench" chainspec Oct 28, 2022
@mnaamani
Copy link
Copy Markdown
Member Author

mnaamani commented Oct 28, 2022

I'll have to test if the --tmp flag also works when using the "benchmark" command.

It's only available when running a full chain, not when running the benchmark command.

I renamed "prod" to "prod-test"

@mnaamani mnaamani requested a review from Lezek123 October 28, 2022 20:36
@mnaamani mnaamani changed the title "bench" chainspec "prod-test" chainspec Nov 1, 2022
@mnaamani mnaamani changed the base branch from carthage-weights-gen to carthage November 2, 2022 19:16
Lezek123
Lezek123 approved these changes Nov 3, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Lezek123 Lezek123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnaamani mnaamani merged commit 29d3b56 into Joystream:carthage Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dobertRowneySr dobertRowneySr Awaiting requested review from dobertRowneySr

1 more reviewer

@Lezek123 Lezek123 Lezek123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mnaamani @Lezek123