Carthage update from master#4379
Merged
mnaamani merged 8 commits intoJoystream:carthagefrom Oct 17, 2022
Merged
Conversation
…_upgrade github actions dependencies version update
…resources Qn map metadata for external resources for members
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Lezek123
reviewed
Oct 17, 2022
Contributor
Lezek123
left a comment
There was a problem hiding this comment.
Looks good, however I noticed that we're still using outdated version for some GH actions:
Is there a specific reason for this, or were they just overlooked?
Member
Author
Maybe overlooked, I'll double check. |
Lezek123
suggested changes
Oct 17, 2022
Lezek123
approved these changes
Oct 17, 2022
Contributor
Lezek123
left a comment
There was a problem hiding this comment.
LGTM if the CI checks pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging master branch into carthage,
dropping commented out code related to building for raspberry-pi armv7 (32-bit)
┆Issue is synchronized with this Asana task by Unito