Skip to content

global funding proposal#4338

Merged
dobertRowneySr merged 13 commits intoJoystream:carthagefrom
dobertRowneySr:carthage-global-fundnig-proposal
Oct 14, 2022
Merged

global funding proposal#4338
dobertRowneySr merged 13 commits intoJoystream:carthagefrom
dobertRowneySr:carthage-global-fundnig-proposal

Conversation

@dobertRowneySr
Copy link
Copy Markdown
Collaborator

@dobertRowneySr dobertRowneySr commented Oct 4, 2022

Addresses #4333

Changes

  • rename max amount into max total amount (total amount for the funding proposal)
  • refactor check in proposals/codex/lib.rs to check funding <= max amount
  • add failing test for constraint violations
  • generate types and metadata

┆Issue is synchronized with this Asana task by Unito

@vercel
Copy link
Copy Markdown

vercel bot commented Oct 4, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
pioneer-testnet ⬜️ Ignored (Inspect) Oct 14, 2022 at 10:10AM (UTC)

@dobertRowneySr dobertRowneySr marked this pull request as ready for review October 5, 2022 08:22
Ignazio Bovo and others added 5 commits October 12, 2022 18:58
Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
@dobertRowneySr dobertRowneySr changed the title feat: max amount checked against total proposal amount global funding proposal Oct 13, 2022
Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
Copy link
Copy Markdown
Contributor

@Lezek123 Lezek123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs conflict resolution

@dobertRowneySr dobertRowneySr merged commit 6c67c24 into Joystream:carthage Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants