Channel payouts: Mappings, CLI, Integration-tests, TS lib#4334
Channel payouts: Mappings, CLI, Integration-tests, TS lib#4334mnaamani merged 70 commits intoJoystream:ephesusfrom
Conversation
|
@zeeshanakram3 as discussed I'm updating ephesus branch here #4430 Once that is merged you can re-target this PR to ephesus |
There was a problem hiding this comment.
Thanks for making the package hybrid! We verified that it works properly with Atlas now, without the need for patching which is great. LGTM from me and @drillprop
There's some failing test though, not sure what that is about
I'll re-run them, but a proper fix for this occasional failure is in carthage branch now |
|
btw, @mnaamani @zeeshanakram3, Atlas team will need those new libraries published so that we can consume them and start developing. That's new version of |
Carthage cli multisig fixes
|
@zeeshanakram3 I retargeted the PR to ephesus branch. Perhaps you can rebase PR on ephesus just to be sure its all good. |
mnaamani
left a comment
There was a problem hiding this comment.
Please update PR from ephesus branch and bump metadata-protobuf package version to 3.0.0
| { | ||
| "name": "@joystream/metadata-protobuf", | ||
| "version": "2.5.0", | ||
| "version": "2.6.0", |
There was a problem hiding this comment.
Lets bump this to v3.0.0 to allow for version updates on carthage/mainnet in the 2.x.x range.
And of course update the dependent packages.
There was a problem hiding this comment.
Sure. btw moving forward, wouldn't it be a better solution to have something like 2.6.0-beta for pre-production /testing releases instead of reserving some range for a specific release, i.e., 2.x.x range for carthage/mainnet. This way, devs can be more open to following semantic versioning guidelines properly, i.e., bumping major versions too in case of breaking changes/new features
There was a problem hiding this comment.
Sorry, but I haven't made the version bump change yet; I was just confirming if it's fine to do it this way before making the change. So will you reopen this PR, Or should I create a separate PR including the version change, i.e., setting @joystream/metadata-protobuf version to 2.6.0-beta
@mnaamani
6bce8a7 to
518df40
Compare
supersedes #3879 & #3182
Tracking issue #3880