Carthage poa npos tests#4315
Merged
mnaamani merged 116 commits intoJoystream:carthagefrom Oct 15, 2022
Merged
Conversation
prevent new era from occurring, effectively: - stopping validator set election and update - stopping era payout from being updated - keeping the same validator set (PoA)
in order to save new runtime build to docker
Lezek123
suggested changes
Oct 7, 2022
tests/network-tests/src/fixtures/staking/ValidatingSucceedsFixture.ts
Outdated
Show resolved
Hide resolved
tests/network-tests/src/flows/carthage/carthagePoAAssertions.ts
Outdated
Show resolved
Hide resolved
tests/network-tests/src/flows/carthage/carthagePoAAssertions.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
- 30 seconds sessions - wait for `era_blocks` for poa assertions - wait for new era elections before Npos assertions
Lezek123
suggested changes
Oct 13, 2022
Contributor
Lezek123
left a comment
There was a problem hiding this comment.
I fixed a few bugs in the tests and added some extra assertions, please take a look: dobertRowneySr#8
added 2 commits
October 14, 2022 03:39
A few POA->NPoS tests adjustments
Lezek123
suggested changes
Oct 14, 2022
Co-authored-by: Leszek Wiesner <leszek@jsgenesis.com>
Lezek123
approved these changes
Oct 14, 2022
mnaamani
approved these changes
Oct 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements #4269 (testing plan comment)
I did not use
chai-as-promisedpackage since it wasn't strictly necessary