Skip to content

Proposals v2. Iteration 4. Discussion system for the proposals.#175

Merged
bedeho merged 14 commits intoJoystream:proposals_v2from
shamil-gadelshin:proposals_v2_iteration4
Mar 2, 2020
Merged

Proposals v2. Iteration 4. Discussion system for the proposals.#175
bedeho merged 14 commits intoJoystream:proposals_v2from
shamil-gadelshin:proposals_v2_iteration4

Conversation

@shamil-gadelshin
Copy link
Copy Markdown
Contributor

Old PR discussion can be found here shamil-gadelshin#2.

Features and comments:

  1. discussion system prototype supports API and extrinsics:
  • create_thread()
  • add_post()
  • update_post()
  1. codex integrates proposals from the engine module with discussion threads from the discussion module
  2. membership module integration is postponed until post-Rome: Map Substrate origin parameter to the MemberId and CouncillorId in the proposals module #174
  3. post storage is implemented via double_map
  4. constant parameters were redesigned as Get<> implementation instead of config()

- plain implementation (no ensures)
- simple test
Add virtual workspace Cargo.toml for the proposals module with three modules:
- engine
- codex
- discussion
- add update_post() extrinsic with tests
- rename create_discussion() to the create_thread()
- change MaxPostEditionNumber from config() to Get<> parameter in the discussion proposal module
- add ‘title is empty’ check
- add ‘title is too big’ check
Add ensure_* for:
- add_post
- update_post
# Conflicts:
#	modules/proposals/codex/src/lib.rs
#	modules/proposals/engine/src/tests/mod.rs
@shamil-gadelshin shamil-gadelshin requested a review from bedeho March 2, 2020 10:05
Copy link
Copy Markdown
Member

@bedeho bedeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@bedeho bedeho merged commit 79f4978 into Joystream:proposals_v2 Mar 2, 2020
@iorveth iorveth mentioned this pull request Apr 13, 2020
45 tasks
@shamil-gadelshin shamil-gadelshin deleted the proposals_v2_iteration4 branch June 25, 2020 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants