Skip to content

Create recurring reward relationship for curator when filling role#123

Merged
bedeho merged 3 commits intoJoystream:developmentfrom
mnaamani:wg-fix-fill_curator_opening
Feb 12, 2020
Merged

Create recurring reward relationship for curator when filling role#123
bedeho merged 3 commits intoJoystream:developmentfrom
mnaamani:wg-fix-fill_curator_opening

Conversation

@mnaamani
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Member

@bedeho bedeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Now that I am seeing the usage of the mint, perhaps we want to have the flexibility to have different mints over time, or not set it from the get go, or not have to be forced to somehow ensure that its set before a call to fill an opening. In which case an optional mint_id could make sense. What do you think?

  • Better to unpack the construction of reward_relationship into multiple steps, its a bit to clever right now.

@mnaamani
Copy link
Copy Markdown
Member Author

Now that I am seeing the usage of the mint, perhaps we want to have the flexibility to have different mints over time, or not set it from the get go, or not have to be forced to somehow ensure that its set before a call to fill an opening. In which case an optional mint_id could make sense. What do you think?

I agree having an optional mint is more flexible. If we choose that approach we will need to add a few more dispatchable calls to support managing mints in general (remember the mint module has not dispatchable calls). We still need some dispatchables in any case just to manage the mint created at genesis.

However I would prefer having a simpler setup of one mint generated at genesis that is well managed by the Lead. At least for Rome this will be sufficient.

I will fix conflict and update implementation of constructing reward relationship.

Copy link
Copy Markdown
Member

@bedeho bedeho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, agreeing with your assessment, will merge.

@bedeho bedeho merged commit e4b618f into Joystream:development Feb 12, 2020
@mnaamani mnaamani deleted the wg-fix-fill_curator_opening branch May 22, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants