content working group: create mint and optionaly lead at genesis#119
Merged
bedeho merged 4 commits intoJoystream:developmentfrom Feb 12, 2020
Merged
content working group: create mint and optionaly lead at genesis#119bedeho merged 4 commits intoJoystream:developmentfrom
bedeho merged 4 commits intoJoystream:developmentfrom
Conversation
bedeho
reviewed
Feb 10, 2020
Member
bedeho
left a comment
There was a problem hiding this comment.
- Looking at the original issue you pointed out here #87 (comment), it's not clear to me what exactly the problem is. The fact that the mint module cannot be configured with a mint at genesis currently is not really an obstacle to this id being configurable here, because we have often just used configurability as a way to setup tests, not per say to setup genesis states. Am I missing something here?
- Even if we could not have it configurable for this reason, then I think it would be simpler to just make it optional, as you suggest, or drop it entirely. Right now, its not even used in the content working group as far as I can tell?
Do we need to set the lead at genesis, if not, then I would prefer to remove all of that add_extra_genesis code also.
Member
Author
|
Regarding setting lead at genesis, no there is no necessity but my fix was really in response to the code comment that it was "Not configurable, because default set value breaks semantics". So we can drop it. |
Member
Author
|
Regarding the mint configuration will respond in and related issue here |
bedeho
approved these changes
Feb 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses - #87 (comment)
from list of issues: #117