fix: remove 'Codec' import from template files in generated/types dir#513
Merged
zeeshanakram3 merged 1 commit intoJoystream:masterfrom Jan 11, 2023
Merged
Conversation
affects: @joystream/hydra-typegen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In module.hbs file in
hydra-typegenpackage, there is an unused Codex import as:import { Codec } from "@polkadot/types/types";. This template file is being used to generate Events classes for each module insidequery-node/mappings/generated/types/. The problem is if any event contains a param which is of codex type, thenCodecis imported again, which leads to duplicate imports error while building the QN.For example, in Joystream/joystream#4517 the type of optional payment parameter in the MemberRemarked event is
Option<[AccountId32, u128] & Codec>Solution
Remove unused
Codecimport from the template file.affects: @joystream/hydra-typegen