Introduce CallToActionButton component and implement it in views that need it#1025
Merged
kdembler merged 7 commits intoJoystream:video-content-pagesfrom Jul 28, 2021
Merged
Conversation
Contributor
Author
4a8fa4b to
a6b244c
Compare
265859c to
7c5e222
Compare
a6b244c to
b46908f
Compare
e9ad33b to
fc4c7ff
Compare
drillprop
reviewed
Jul 27, 2021
Contributor
drillprop
left a comment
There was a problem hiding this comment.
Just two small things. Looks really cool btw!
| const linkProps = getLinkPropsFromTo(to) | ||
|
|
||
| return ( | ||
| <StyledContainer {...linkProps} onClick={onClick} colorVariant={colorVariant}> |
Contributor
There was a problem hiding this comment.
To fix this you could use shouldForwardProp like I did https://github.com/Joystream/atlas/pull/1016/files
| icon?: ReactNode | ||
| colorVariant?: ColorVariants | ||
| label: string | ||
| } |
Contributor
There was a problem hiding this comment.
I'm not sure if we should create another file just to add these types. We could just keep them inside CallToActionButton.tsx
Contributor
There was a problem hiding this comment.
Yep, could make sense for bigger component I think
kdembler
reviewed
Jul 27, 2021
| icon?: ReactNode | ||
| colorVariant?: ColorVariants | ||
| label: string | ||
| } |
Contributor
There was a problem hiding this comment.
Yep, could make sense for bigger component I think
Comment on lines
+20
to
+21
| label="Browse channels" | ||
| to={absoluteRoutes.viewer.browseChannels()} |
Contributor
There was a problem hiding this comment.
Shouldn't this use the /channels we have currently for now?
drillprop
reviewed
Jul 28, 2021
src/shared/components/CallToActionButton/CallToActionButton.style.ts
Outdated
Show resolved
Hide resolved
kdembler
approved these changes
Jul 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1010