Skip to content

ci: remove node 25 from test matrix#776

Merged
JoshuaKGoldberg merged 1 commit intoJoshuaKGoldberg:mainfrom
michaelfaith:ci/remove-node-v25-tests
Jan 2, 2026
Merged

ci: remove node 25 from test matrix#776
JoshuaKGoldberg merged 1 commit intoJoshuaKGoldberg:mainfrom
michaelfaith:ci/remove-node-v25-tests

Conversation

@michaelfaith
Copy link
Copy Markdown
Contributor

PR Checklist

Overview

Per vitest-dev/vitest#8757, vitest is throwing errors in node v25 due to some issues with the new webstorage api. Once this issue is resolved upstream, latest should be re-enabled.

Per vitest-dev/vitest#8757, vitest is throwing errors in node v25 due to some issues with the new webstorage api. Once this issue is resolved upstream, `latest` should be re-enabled.
@michaelfaith michaelfaith marked this pull request as ready for review December 31, 2025 19:27
@michaelfaith michaelfaith mentioned this pull request Dec 31, 2025
3 tasks
Copy link
Copy Markdown
Owner

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.46%. Comparing base (f13a881) to head (9454320).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   61.46%   61.46%           
=======================================
  Files          35       35           
  Lines        2948     2948           
  Branches      473      473           
=======================================
  Hits         1812     1812           
  Misses       1136     1136           
Flag Coverage Δ
4.8.4 60.07% <ø> (ø)
latest 60.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@michaelfaith
Copy link
Copy Markdown
Contributor Author

michaelfaith commented Dec 31, 2025

@JoshuaKGoldberg I feel like I've seen this is happening in some of the repos we share too(?), where it thinks it should be waiting on these steps, even though they've run. Have you been seeing this recently too (seems like just in the last day or two)

screenshot of builds

@JoshuaKGoldberg
Copy link
Copy Markdown
Owner

I think this happens when I run npx create-typescript-app when the repo has divergent settings, don't push the changes to origin, and forget to reset branch settings...

@JoshuaKGoldberg
Copy link
Copy Markdown
Owner

test (latest, 4.8.4) Expected — Waiting for status to be reported Required>
test (latest, latest) Expected — Waiting for status to be reported Required

😕 These are not in the ruleset settings for main...

@michaelfaith
Copy link
Copy Markdown
Contributor Author

Anything I need to do to move this forward?

@JoshuaKGoldberg JoshuaKGoldberg merged commit 0d938cd into JoshuaKGoldberg:main Jan 2, 2026
23 checks passed
@JoshuaKGoldberg
Copy link
Copy Markdown
Owner

I poked around again and couldn't figure out the pending checks. Given that this is blocking #772 I don't think we should wait. Merged. Thanks as always @michaelfaith, you're a lifesaver!

@michaelfaith michaelfaith deleted the ci/remove-node-v25-tests branch January 2, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🛠 Tooling: Test failures in CI on main

2 participants