feat: use Prettier's CLI function in-memory if possible#144
Merged
JoshuaKGoldberg merged 1 commit intomainfrom Jun 12, 2025
Merged
feat: use Prettier's CLI function in-memory if possible#144JoshuaKGoldberg merged 1 commit intomainfrom
JoshuaKGoldberg merged 1 commit intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 8 +4
Lines 109 146 +37
Branches 25 30 +5
=========================================
+ Hits 109 146 +37 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🎉 This is included in version v0.3.0 🎉 The release is available on: Cheers! 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Augments the built-in Prettier formatter by making its runner a function that attempts to
require()Prettier's internal CLIrunfunction. This is very hacky and unfortunate but I couldn't find another way to run in-memory. Filed: prettier/prettier#17422The change ended up needing a bit more refactoring than I thought:
createRunCommand()->runFormatterCommand()to run a single CLI commandrunPrettierthat falls back torunFormatterCommand()if neededtypes.tsfile to avoid circular dependencies🧼