Skip to content

Tests: make assertions platform-neutral#2376

Open
fuguiKz wants to merge 1 commit intoJoshClose:masterfrom
fuguiKz:tests/platform-neutral-assertions
Open

Tests: make assertions platform-neutral#2376
fuguiKz wants to merge 1 commit intoJoshClose:masterfrom
fuguiKz:tests/platform-neutral-assertions

Conversation

@fuguiKz
Copy link

@fuguiKz fuguiKz commented Jan 2, 2026

Fixes #2375

This is tests-only (no behavior change). It makes a few assertions resilient to platform differences:

  • Build newline-sensitive expected output using cw.Configuration.NewLine/TestStringBuilder (avoids checkout EOL differences).
  • Use an invalid culture name that reliably throws on ICU + Windows NLS.
  • Build expected DateTime output via dob.ToString(culture) to handle ICU's narrow no-break space.

Verification (Linux):

  • dotnet test tests/CsvHelper.Tests/CsvHelper.Tests.csproj -c Release -f net8.0

@fuguiKz fuguiKz mentioned this pull request Jan 2, 2026
Open
@fuguiKz
Copy link
Author

fuguiKz commented Jan 3, 2026

Note: the GitHub Actions check suite is currently in an action_required state (fork workflow approval), so CI hasn't executed yet.

Would a maintainer be able to approve and run the workflows for this PR?

This is tests-only (no behavior change). Local verification (Linux): dotnet test tests/CsvHelper.Tests/CsvHelper.Tests.csproj -c Release -f net8.0 ✅

@fuguiKz fuguiKz mentioned this pull request Jan 3, 2026
Open
@fuguiKz
Copy link
Author

fuguiKz commented Jan 17, 2026

Friendly ping: GitHub Actions checks are still showing as action_required for this fork PR (workflows need maintainer approval before they can run). If you’re OK with it, could you approve the workflows so CI can run on the latest commit (462e445)? Happy to respond quickly to any CI failures or review feedback. Thanks!

@fuguiKz
Copy link
Author

fuguiKz commented Jan 30, 2026 •
edited
Loading

Friendly ping: GitHub Actions are still not running for this fork PR (checks show as action_required).

Could a maintainer approve/run the workflows so CI can execute on the latest commit? Happy to iterate quickly on any failures/review feedback. Thanks!

@fuguiKz
Copy link
Author

fuguiKz commented Mar 1, 2026

Friendly ping: this PR is meant to unblock the Linux/net8.0 test failures tracked in #2375 by making the assertions platform-neutral. If you’d like CI signal here, could you please approve/run the Actions workflows for this fork PR? Happy to adjust based on any failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dotnet test net8.0 fails on Linux (newline/culture differences)

1 participant

@fuguiKz