0.5 by JoryHogeveen · Pull Request #36 · JoryHogeveen/off-canvas-sidebars

JoryHogeveen · 2017-09-12T21:20:42Z

Changelog

Feature: Make closing the slidebar after clicking a link an option. Make auto-close sidebars when clicking a link a setting #47 & Sidebar closes when user scrolls it with touch #48
Feature: Add icon options in control trigger API and shortcode.
Feature: Enhance widget UI with advanced options for control triggers. Improve widget UI and options #27
Enhancement: Setting page JS and UI enhancements.
Enhancement: Use data attributes to conform W3C HTML5 specifications. Conform to W3C HTML5 specifications #50
Enhancement: Add support links on plugins overview page.
Refactoring: Separate classes for tabs, page and settings/validation. Enhances plugin option validation. Refactor tabs and settings #38
Refactoring: Global OCS_DOMAIN constant.
Updated/Added: Screenshots.

Other

Test update from 0.4.x
Readme update
Wiki update

Unit tests #34

Setting pages > Save options
- General
  - Check validators
  - Check compare with input data
  - Check compare with default data
  - Check compare with current data
- Sidebars
  - Check validators
  - Check compare with input data
  - Check compare with default data
  - Check compare with current data
API
- Shortcodes. Will validate the following functions through the shortcode:
  - shortcode_ocs_trigger()
  - the_ocs_control_trigger()
  - OCS_Off_Canvas_Sidebars_Frontend::do_control_trigger()
  - off_canvas_sidebars_parse_attr_string()

- Separate classes for tabs, page and settings/validation - Global OCS_DOMAIN constant

# Conflicts: # includes/class-frontend.php

…ling requests)

# Conflicts fixed: # css/off-canvas-sidebars.css # css/off-canvas-sidebars.min.css # off-canvas-sidebars.php

…ance code

Trim spaces and semicolons

Full refactor of settings and page code structure

1cde526

- Separate classes for tabs, page and settings/validation - Global OCS_DOMAIN constant

JoryHogeveen added enhancement refactoring labels Sep 12, 2017

JoryHogeveen added this to the 0.5 milestone Sep 12, 2017

JoryHogeveen self-assigned this Sep 12, 2017

JoryHogeveen added 14 commits September 15, 2017 00:17

phpDoc + minor code improvements

712e9a7

Enhance form actions

5626a6c

Enhance setting handlers

4ce7378

Move main class to separate class file

9f6edd8

Class phpDoc + spelling

f2aed68

Make form handling work again. Needs improvement!!

5d33758

code element display + css doc

71db0b2

Merge remote-tracking branch 'refs/remotes/origin/dev' into 0.5

b0d05f9

# Conflicts: # includes/class-frontend.php

Fix request tab handlers (current tab is always the default when hand…

1bd9df6

…ling requests)

ocs_update not needed

49c1a10

Add current settings param on ocs_settings_parse_input filter

053ba55

Enhance option labels and descriptions

20edbbc

Merge remote-tracking branch 'refs/remotes/origin/master' into 0.5

d8f05c8

# Conflicts fixed: # css/off-canvas-sidebars.css # css/off-canvas-sidebars.min.css # off-canvas-sidebars.php

Merge remote-tracking branch 'refs/remotes/origin/master' into 0.5

b043e70

JoryHogeveen force-pushed the 0.5 branch from 1cb08b3 to b043e70 Compare October 19, 2017 12:29

JoryHogeveen and others added 7 commits November 13, 2017 23:18

Merge remote-tracking branch 'refs/remotes/origin/master' into dev

54e4975

Merge branch 'dev' into 0.5

9147296

Link close setting

841b76a

Link close option

2ee3ad4

Move slidebar input validation logic to the slidebars tab class + enh…

9fd5338

…ance code

Merge remote-tracking branch 'refs/remotes/origin/master' into dev

0ab5a67

Merge remote-tracking branch 'refs/remotes/origin/dev' into 0.5

b42afd9

JoryHogeveen added the feature label Dec 7, 2017

JoryHogeveen added 2 commits January 3, 2018 01:31

File codeblocks + comments + versions

bd7bcff

link_close: Prevent touch swipe

60f1369

JoryHogeveen added 4 commits June 5, 2018 22:27

Class key should be a string in this case

1963fc6

New method for parsing values

b25d682

Remove defaults in a new method

2f42b7e

Check if there are advanced options set before hiding them

5d0c8b6

JoryHogeveen changed the base branch from dev to master June 5, 2018 20:53

JoryHogeveen changed the title ~~0.5-dev~~ 0.5 Jun 5, 2018

JoryHogeveen added 22 commits June 5, 2018 23:31

Allow empty attributes

1077032

Check for faulty endings in attributes

077bfc7

Trim spaces and semicolons

Unit tests for plugin API

cb1b32c

Fix codeclimate issues

63825c9

Suppress some codeclimate warnings

7069e7d

Reduce complexity of do_control_trigger()

5b0f56e

Make parse_to_html_attr() accessible from all classes

22ba137

Minor enhancements in widget UI

6e18ca2

Patch changes in logic to unit tests

7b0edf8

v0.5-rc2

a780986

Add links to the plugin overview page

d369893

Add icons & translate link in credits box

66cf6bb

Wake up...

36eefd7

Add link_close to the global toggle setting

7a71bfd

Update strings

6597844

Update screenshots

d514325

Readme changelog update

80a8428

Copyright date

38ddb56

v0.5

14bad9f

Hotfix: Tab filters

4f43dd6

Hotfix: the_ocs_control_trigger() phpdoc

8623271

Hotfix: Add changelog PR link

257596c

JoryHogeveen merged commit 9d0d824 into master Jun 7, 2018

JoryHogeveen deleted the 0.5 branch June 7, 2018 15:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

0.5#36

0.5#36
JoryHogeveen merged 129 commits intomasterfrom
0.5

JoryHogeveen commented Sep 12, 2017 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

JoryHogeveen commented Sep 12, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

JoryHogeveen commented Sep 12, 2017 •

edited

Loading