Safer publication of the resolved LF#8
Closed
cl4es wants to merge 1 commit intoJornVernee:BootstrapJavafrom
Closed
Safer publication of the resolved LF#8cl4es wants to merge 1 commit intoJornVernee:BootstrapJavafrom
cl4es wants to merge 1 commit intoJornVernee:BootstrapJavafrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structuring so that the
LF::resolvereturns the membername, which is then properly installed into the outer mh by means ofmh::updateForm. This is a plausible or at least partial fix to a safe publication issue where the LF might end up in an inconsistent state, and with this changemake test TEST=jdk_foreignhas passed 10 times in a row for me. To be ideal we should refactor compileBytecode et.c. to not side-effectlf.vmentryetc directly. We should also re-examineisResolvedsince it might be redundant with this protocol