Skip to content

Browser Refresh button; Update Menu to git pull module changes; Alert…#10

Merged
Jopyth merged 1 commit intoJopyth:developfrom
MonkoftheFunk:feature_refresh_update_alert
Nov 13, 2016
Merged

Browser Refresh button; Update Menu to git pull module changes; Alert…#10
Jopyth merged 1 commit intoJopyth:developfrom
MonkoftheFunk:feature_refresh_update_alert

Conversation

@MonkoftheFunk
Copy link
Copy Markdown
Contributor

Added

  • Browser Refresh button
  • Update Menu to git pull module changes
  • Alert Menu to send alerts/notifications to mirror
  • Restart will also refresh browser page after 60 seconds
  • Successful status updates with 'info' will show alert

*might need to fix some of the tabbing blips that didn't show up

… Menu to send alerts/notifications to mirror; Restart will also refresh browser page after 60 seconds; Successful status updates with 'info' will show alert
@Jopyth
Copy link
Copy Markdown
Owner

Jopyth commented Nov 9, 2016

@MonkoftheFunk
Copy link
Copy Markdown
Contributor Author

I don't know why executing a shell command causes an error command not found, but still executes just fine. I feel like it's a node thing because it doesn't wrap command in quotes. But I'm new.

@Jopyth
Copy link
Copy Markdown
Owner

Jopyth commented Nov 10, 2016

Is the comment about the git command? Or something else?

@Jopyth
Copy link
Copy Markdown
Owner

Jopyth commented Nov 10, 2016

I will test and review this on the weekend, thanks! I like the alert send especially.

@MonkoftheFunk
Copy link
Copy Markdown
Contributor Author

It's about any command, I used pm2 logs to see the errors but the commands still run.

@MonkoftheFunk
Copy link
Copy Markdown
Contributor Author

Another feature I'm thinking about is an ability to upload and show an image using alert.

@Jopyth Jopyth merged commit 2978af9 into Jopyth:develop Nov 13, 2016
@Jopyth
Copy link
Copy Markdown
Owner

Jopyth commented Nov 13, 2016

Thanks, merged! I changed some things, mostly visuals/style, so if you want to add new things, such as the image upload, make sure to base your new features on the updated branch.

@Jopyth
Copy link
Copy Markdown
Owner

Jopyth commented Nov 13, 2016

As for the command failed, I have the messages now, too. Will make a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants