Support --respect-ignores
#765
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
=======================================
Coverage 97.54% 97.54%
=======================================
Files 16 16
Lines 6146 6146
=======================================
Hits 5995 5995
Misses 151 151 ☔ View full report in Codecov by Sentry. |
…espect-ignores
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, files explicitly passed to the command line stylua (e.g.
stylua foo.lua) will be formatted regardless of whether they are present within the.styluaignorefile or not. This is due to the assumption that explicit files are expected to be formatted as the user provided them directly.We add in a flag
--respect-ignoresthat should be used to check the ignore file first before formatting.Existing editor tools should migrate to this flag to respect
.styluaignorein IDEs, rather than rolling their own logic (the VSCode extension currently has its own logic for ignore detection).Fixes #751 and Fixes #377
TODO: right now
stylua --stdin-filepath path/to/ignored.lua -doesn't consider this flag, and always ignores the file. It should migrate to respecting the flag