Allows RPC methods to be called on client object directly#19
Merged
JohnDoee merged 1 commit intoJohnDoee:developfrom May 20, 2018
Merged
Allows RPC methods to be called on client object directly#19JohnDoee merged 1 commit intoJohnDoee:developfrom
JohnDoee merged 1 commit intoJohnDoee:developfrom
Conversation
4 tasks
Owner
|
Since the official Deluge client does it this way, I don't mind adding it. My problem with it is that it hides away you're doing a network call and make it seem like a local function call. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure if you are in to this, it allows an alternate method of calling RPC functions:
can be called instead like
I am a little dubious, since we can't validate what's a valid method, and deluge doesn't seem to send back any error with invalid methods, but that's true for the
.call()format as well.