Don't crash when accessing SSLError.reason if it does not exist.#12
Don't crash when accessing SSLError.reason if it does not exist.#12JohnDoee merged 2 commits intoJohnDoee:developfrom
Conversation
|
I found the error code: 258 It seems like it is found in the attribute Since python 2.7.9 is only 4ish years old, it is probably still required to have support for this. Can you please add support for that? I'll add an ancient python version to the test matrix (while adding support for the upcoming version auto-detection). |
|
Yeah, I found that code too, but I'm not sure how to reproduce the UNSUPPORTED_PROTOCOL error, so I couldn't verify that the error code actually came. Do you know how to reproduce? |
|
Not while connecting to deluge, my plan so far has been to (write and) run a small SSL server that it can't negotiate a working connection with. The original problem stems from some disparity in Debian. |
|
I added the check for errno. I left the 'reason' check in though as well, since I haven't confirmed we actually get that error number. |
|
Thanks, I've found it somewhat hard to actually reproduce the error. It only happens with certain setups and combinations of software. |
This fixes #5. Python < 2.7.9 does not have a
reasonattribute on anSSLErrorexception.It does not address this note #5 (comment) I think another ticket should be created if there is a problem with timeouts.