Merged
Conversation
fix: remove reference to e_arrange incompatibility with shiny in the e_text_style documentation
fix: swapping out bootstrap 4 for bootstrap 5 ; note this fixes problems with e_arrange importing bs4 and _reboot.scss overwriting custom.css annoyingly.
fix: small typo
Collaborator
|
LGTM thx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi ,
I have a pull request to run by you composed of two parts.
The first removes reference to ' do not use e_arrange in shiny' in the e_text_style docs. I don't believe it has any reason to be there.
Secondly, using e_arrange in shiny 'works' somewhat, but not seamlessly. Updating to NS5 (when working with bslib and bs5) seems to work much better. My issue was that _reboot.scss stylesheets were overwriting my custom.css when the bs4 library was imported. Instead of updating the disclaimer erroneously posted in the e_text_style docs, that e_arrange should be avoided in shiny, I updated the CDN to point to BS5.3.3 (jsdeliver). I note stackpath may be going out of business. The classes leveraged from BS4 are the same in BS5.
If instead better warnings (there are none) should be in place and the CDN left as it is, is at your discretion.
Again thank you for your work on this. Best, Aaron.
What
How
Why