feat: allow setting node XY coordinates when layout="none"#599
Merged
JohnCoene merged 3 commits intoJohnCoene:masterfrom Dec 6, 2023
Merged
feat: allow setting node XY coordinates when layout="none"#599JohnCoene merged 3 commits intoJohnCoene:masterfrom
JohnCoene merged 3 commits intoJohnCoene:masterfrom
Conversation
Owner
|
Thanks, LGTM. Could you add yourself as |
Contributor
Author
|
@JohnCoene I added my self as ctb. Thanks! |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! I was trying to create a graph similar to this: https://echarts.apache.org/examples/en/editor.html?c=graph-simple, where the user passes X and Y coordinates for the nodes. But, it seems that
e_graph()does not have this feature. Looks like it does not render anything whenlayout = "none". After some poking around, it seemed like there was no way to pass X and Y coordinates, so I tried to implement it by updating thee_graph_nodesfunctions and the associated.helpers fromutils.R.With this update, a user can now set fixed node positions with a call like: