Documentation: implementing a static grid for small charts#564
Merged
munoztd0 merged 4 commits intoJohnCoene:masterfrom Oct 2, 2023
Merged
Documentation: implementing a static grid for small charts#564munoztd0 merged 4 commits intoJohnCoene:masterfrom
munoztd0 merged 4 commits intoJohnCoene:masterfrom
Conversation
Collaborator
|
Great, thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a followup to this issue: #558
A solution for creating small eCharts objects (e.g. height of sub 100px) was described, which involves setting a static grid so the resulting chart doesn't outgrow it's parent div.
This PR adds this explanation to the documentation of the
e_charts,echarts4rOutput,renderEcharts4r... functions.Also fixed a typo in the e_charts() reorder argument documentation.
Note: I'm not sure if the man/.Rd files need to be included in the PR, or if they are built automatically during CI/CD. If they're needed, I'll add them :)