Implement diffs for pkgbuild viewing.#447
Conversation
|
This follows the default |
|
I'll check it out. Would you prefer to always go to less or that they should be always printed directly? |
|
I would like it to always go to less, but then piping manually is more annoying and less wont display colour without the |
|
Git uses There's another problem with empty diffs but that should be an easy fix. |
diff viewing can be toggled via --[no]showdiffs. When enabled diffs will be shown for packages between the current HEAD and upstream's HEAD. Packages downloaded via tarballs will be shown in full using the editor git diff is used to show diffs. Therefore the pager for diffs can be set via the PAGER and GIT_PAGER enviroment variables.
|
I changed the UX a little, I'd say I'm happy with it. Setting |
|
@Morganamilo after I check the diff of an upgrade package how would I go about editing that PKGBUILD? |
|
You'd have to open the file in your editor yourself or use --noshowdiffs. This is why I had the diffs always show the full file paths. I don't know how important editing is to you. I always saw it as viewing but you also happened to be in an editor. I thought It would be tedious to have edit and diff prompts at the same time. Maybe you can think of something that works. |
|
Requires more work: Less work: For me the less work option works |
|
Thinking about it, Would probably work to replace the |
|
Yes maybe it would work, I'll try and think of designs over that as welll |
diff viewing can be toggled via --[no]showdiffs. When enabled diffs will
be shown for packages between the current HEAD and upstream's HEAD.
Packages downloaded via tarballs will just have their pkgbuilds printed.
git diff is used to show diffs. Therefore the pager for diffs can be
shown via the PAGER and GIT_PAGER enviroment variables.
Fixes #131 after all this time.