KT-72172 Dispose URLClassLoader after compilation#5372
Merged
Brian Norman (bnorm) merged 1 commit intoNov 7, 2024
Merged
Conversation
Closes `URLClassLoader` objects upon compilation completion.
Contributor
Author
|
Something that laszio (@ting-yuan) mentioned, this issue can have a negative impact on Windows users due to this:
|
Member
|
Unfortunately, as it currently exists, this PR is a little incomplete. There are a couple of compiler errors due to the signature change in PluginCliParser. But this is a problem we have also been wanting to fix. So I'm going to retarget your code to a branch of my own and build on your solution to finish it out. Thank you for kick-starting this work! |
66188a3
into
JetBrains:rr/bnorm/KT-72540-close-plugin-classloader
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes
URLClassLoaderobjects upon compilation completion.See: https://youtrack.jetbrains.com/issue/KT-72172/File-Leak-occurring-in-Kotlin-Daemon