Fixed autofill for non-NITI textfields on iOS#2937
Merged
Vladimir Mazunin (mazunin-v-jb) merged 4 commits intoMar 31, 2026
Merged
Conversation
a756919 to
b917cde
Compare
Andrei Salavei (ASalavei)
approved these changes
Mar 31, 2026
| fun hideTextMenu() = this.hideEditMenu() | ||
|
|
||
| fun isTextMenuShown() = isEditMenuShown | ||
| override fun shouldUseNonComposeMenuActions() = usingNativeTextInput |
There was a problem hiding this comment.
should be useNativeTextInput based on the previous PRs 🤔
There was a problem hiding this comment.
I thought that might be confusing in the obj-c class, since it's used only for the menu content, and I'd like to avoid having usingNativeTextInput() in addition to the variable.
Anyway, I was going to separate niti and non-niti in the upcoming text refactoring, and this flag should be unnecessary after that and would be removed.
e4b2667 to
dc55d18
Compare
Vendula Švastalová (svastven)
approved these changes
Mar 31, 2026
dc55d18 to
a739488
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the regression with appeared autofill in non-native textfields on iOS
Fixes:
CMP-9993 [iOS] TextField. The new Autofill context menu item is available in the current implementation
Testing
This should be tested by QA
Release Notes
Fixes - iOS
Autofillcontext menu item in theBasicTextField(TextFieldValue)andBasicTextField(TextFieldState)