Fixed crash during triple tap on empty textfield with usingNativeTextInput flag enabled#2910
Merged
Vladimir Mazunin (mazunin-v-jb) merged 2 commits intoMar 27, 2026
Conversation
Vendula Švastalová (svastven)
requested changes
Mar 25, 2026
Comment on lines
+509
to
+511
| val fallback = IntermediateTextPosition(0) | ||
| PlatformTextLayoutDirection(farthestInDirection)?.let { direction -> | ||
| input?.positionWithinRange(range.toTextRange(), direction)?.let { | ||
| val textRange = range.toTextRange() ?: return fallback |
There was a problem hiding this comment.
Suggested change
| val fallback = IntermediateTextPosition(0) | |
| PlatformTextLayoutDirection(farthestInDirection)?.let { direction -> | |
| input?.positionWithinRange(range.toTextRange(), direction)?.let { | |
| val textRange = range.toTextRange() ?: return fallback | |
| val fallback = IntermediateTextPosition(0) | |
| val textRange = range.toTextRange() ?: return fallback | |
| PlatformTextLayoutDirection(farthestInDirection)?.let { direction -> |
…Input flag enabled
6f3f34e to
a5c1fa9
Compare
Andrei Salavei (ASalavei)
approved these changes
Mar 27, 2026
Vendula Švastalová (svastven)
approved these changes
Mar 27, 2026
8655f8a
into
jb-main
27 of 28 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the crash during triple tap on empty textfield with
usingNativeTextInputflag enabled by changing non-optional cast ofUITextRangetoTextRangeto optionalFixes:
CMP-9881 [ios].niti. Crash during triple tap on empty line with feature flag enabled
Testing
This should be tested by QA
Release Notes
Fixes - iOS
usingNativeTextInputflag enabled