Merge Jetpack Compose 1.11.0-alpha06#2790
Conversation
|
|
||
| import androidx.compose.runtime.Composable | ||
|
|
||
| // TODO(b/352352908): Remove once this API will be available in common |
There was a problem hiding this comment.
Please make sure that using NavigationEvent here is trackable
There was a problem hiding this comment.
I'm not sure I got you. What do you mean by "trackable"?
There was a problem hiding this comment.
We have bug on YT or Google tracker to remove this expect/actual
There was a problem hiding this comment.
Here the change is in commonMain (from upstream).
I added a TODO in nonAndroid main.
| @@ -19,8 +19,7 @@ package androidx.compose.ui.graphics | |||
| import androidx.compose.runtime.Immutable | |||
| import androidx.compose.runtime.Stable | |||
|
|
|||
| // TODO mark internal once https://youtrack.jetbrains.com/issue/KT-36695 is fixed | |||
| /* internal */ expect class NativeColorFilter | |||
| internal expect class NativeColorFilter | |||
There was a problem hiding this comment.
Please add a YT task for actual adoption (assigned to me)
There was a problem hiding this comment.
I guess no YT task neded. I added internal in skikoMain.
| @@ -619,6 +619,8 @@ actual value class Key(val keyCode: Long) { | |||
|
|
|||
| /** Numeric keypad Insert Key. */ | |||
| actual val NumPadInsert = Key(KeyEvent.VK_INSERT, KEY_LOCATION_NUMPAD) | |||
| actual val SystemHome: Key = Key(-1000000184) | |||
| actual val NumPadDelete: Key = Key(KeyEvent.VK_DELETE, KEY_LOCATION_NUMPAD) | |||
There was a problem hiding this comment.
Please keep them sorted like on commonMain, it's really hard to track the match otherwise
There was a problem hiding this comment.
I fixed this particular case (SystemHome). But in general they are not ordered the same way as in expect.
| @@ -33,7 +33,7 @@ builder = "8.6.0-alpha05" | |||
| byteBuddy = "1.14.9" | |||
| asm = "9.7" | |||
| cmake = "3.22.1" | |||
| composeCompilerPlugin = "2.3.0" | |||
| composeCompilerPlugin = "2.3.10" | |||
There was a problem hiding this comment.
Is it compatible with 2.3.0 this time?
There was a problem hiding this comment.
No :(
only k/wasm is affected though
There was a problem hiding this comment.
Add "Release Notes" then
There was a problem hiding this comment.
Is it trackable on KT side? Do we expect a compatibility fix in 2.3.20?
There was a problem hiding this comment.
Added the release note.
I discussed this with k/wasm folks once again:
Their pace of development would drastically slow down if they enforce such limits on stlib changes.
(somewhat okayish for Beta)
…87 - Introduce an experimental Style API
… expect declaration
c35eb82 to
4f433da
Compare
| * * `SafeContentRulers` | ||
| */ | ||
| @ExperimentalComposeUiApi | ||
| var ComposeUiFlags.areWindowInsetsRulersEnabled by SkikoComposeUiFlags::isDialogAnimationEnabled |
There was a problem hiding this comment.
Incorrect mapping, it redirects to isDialogAnimationEnabled now
Fixes https://youtrack.jetbrains.com/issue/CMP-9805/Merge-Jetpack-Compose-1.11.0-alpha06
Testing
N/A
Release Notes
N/A