Update replaceVersion.sh to include components build files#5536
Conversation
| "$ROOT/ci" | ||
| "$ROOT/tutorials" | ||
| "$ROOT/html" | ||
| "$ROOT/components" |
There was a problem hiding this comment.
I remember why I didn't include it in replaceVersion.sh in the first place. The intent was to update public projects with the latest version every release, but keep the publishing projects with a lesser version for compatibility.
Every release we should call this script, and if the latest Kotlin is 2.4.0, we should use it. But we should update publishing projects to Kotlin 2.4.0 only when we decide that we plan to break compatibility (it is usually some AOSP merge).
To keep this intent, we should remove
"$ROOT/html"
"$ROOT/components"
from the script, and either continue to change it manually, or add another script replacePublishingKotlinVersion.sh
Igor Demin (igordmn)
left a comment
There was a problem hiding this comment.
Ok to merge. But let's do a follow-up for the comment
Kotlin version has been bumped in the lastest merge from AOSP to CMP core - https://github.com/JetBrains/compose-multiplatform-core/pull/2790/commits Also I did a follow up for this change - #5536 (comment) (introduced a separate script to update the versions in the libraries) ## Testing N/A ## Release Notes N/A
Also, update components (resources and other libs) to CMP 1.10.0 and Kotlin 2.3.0 (it has not been updated before because replaceVersion.sh missed it).
Other sub-projects already use CMP 1.10.0 and Kotlin 2.3.0
Testing
N/A
Release Notes
N/A