fix some codes to not use platform type and expression style#1582
Merged
Tapac merged 2 commits intoJetBrains:masterfrom Sep 9, 2022
Merged
fix some codes to not use platform type and expression style#1582Tapac merged 2 commits intoJetBrains:masterfrom
Tapac merged 2 commits intoJetBrains:masterfrom
Conversation
Author
|
Can anyone please review it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi i am Heli who using Exposed
First, changed some codes to not use the platform type. platform type requires unnecessary boilerplate(!!, let trick, ...) And open source is a guide to writing code.
so i think bad code examples should be deleted.
Second, change 'when' expression style
thanks. 🙇
--
There is no change that users can feel.