BUG: Need to add targetfolder to PATH when ensuring installed#225
Merged
JessicaTegner merged 1 commit intoJessicaTegner:masterfrom Jul 25, 2021
scottclowe:bug_ensure-PATH
Merged
BUG: Need to add targetfolder to PATH when ensuring installed#225JessicaTegner merged 1 commit intoJessicaTegner:masterfrom scottclowe:bug_ensure-PATH
JessicaTegner merged 1 commit intoJessicaTegner:masterfrom
scottclowe:bug_ensure-PATH
Conversation
Otherwise we will not be able to run pandoc as a subprocess when it is in this arbitrary directory.
Owner
|
Good one! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to add targetfolder to the PATH environment variable otherwise we will not be able to run pandoc as a subprocess when it is housed this arbitrary download location.
This PR addresses issue as discussed in #97 (comment).