Add pyproject.toml to specify build-time requirements#64
Merged
JeremyCCHsu merged 2 commits intoJeremyCCHsu:masterfrom May 25, 2021
Merged
Add pyproject.toml to specify build-time requirements#64JeremyCCHsu merged 2 commits intoJeremyCCHsu:masterfrom
JeremyCCHsu merged 2 commits intoJeremyCCHsu:masterfrom
Conversation
With this, I believe numpy import hack in the setup.py is no longer necessary and it may fix installation issues like JeremyCCHsu#63
NumPy ABI issue: numpy/numpy#16938 Ref: JP article (https://zenn.dev/ymd_h/articles/934a90e1468a05)
r9y9
commented
May 24, 2021
| "wheel", | ||
| "setuptools", | ||
| "cython>=0.24.0", | ||
| "numpy<v1.20.0", |
Contributor
Author
There was a problem hiding this comment.
FYI: this line is necessary to prevent ValueError: numpy.ndarray size changed, may indicate binary incompatibility. Expected 88 from C header, got 80 from PyObject.
Ref: ymd-h/cpprb#3
Contributor
Author
|
Done. CIs are all green. |
Contributor
Author
|
@JeremyCCHsu Could you take a look? |
Owner
|
That was great! Thank you so much @r9y9 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, I believe numpy import hack in the setup.py is no longer necessary and it may fix installation issues like #63