Add first draft of the Jelly-Patch specification#42
Merged
Ostrzyciel merged 11 commits intomainfrom May 6, 2025
Merged
Conversation
adanilenka
reviewed
May 6, 2025
adanilenka
reviewed
May 6, 2025
adanilenka
reviewed
May 6, 2025
adanilenka
reviewed
May 6, 2025
Collaborator
|
@Ostrzyciel If possible, I would suggest adding more info on the PATCH_STREAM_TYPE_PUNCTUATED type. For instance, as both patches and transactions can span multiple patch frames, the explicit wording on "transactions must start and end inside one patch" or smth like that would be nice or that punctuation message should not occur inside an ongoing transaction. |
Co-authored-by: Anastasiya Danilenka <41057639+adanilenka@users.noreply.github.com>
Co-authored-by: Anastasiya Danilenka <41057639+adanilenka@users.noreply.github.com>
Co-authored-by: Anastasiya Danilenka <41057639+adanilenka@users.noreply.github.com>
Member
Author
|
@adanilenka fixed, I think. Could you take a look? |
Collaborator
perfect, I have no more comments, we're good to go :) |
adanilenka
approved these changes
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: Jelly-RDF/jelly-protobuf#11
Follows the proto content from: Jelly-RDF/jelly-protobuf#67
First spec draft formalizing what is written as comments in the proto and how the current prototype implementation in Jelly-JVM behaves.
Notable things:
includesdirectory.