Skip to content

Add the test case vocabulary#65

Merged
Ostrzyciel merged 4 commits intomainfrom
test-case-vocab
May 5, 2025
Merged

Add the test case vocabulary#65
Ostrzyciel merged 4 commits intomainfrom
test-case-vocab

Conversation

@Ostrzyciel
Copy link
Member

Issue: #25

This adds a simple vocabulary for test cases, with two example manifests.

There is no validation or compilation to docs yet.


<triples_rdf_1_1/pos_001> a jellyt:TestPositive, jellyt:TestRdfFromJelly ;
mf:name "A set of three triples with only IRIs as terms" ;
rdfs:comment "A set of three triples with only IRIs as terms. Stream options are: generalized-statements=false, rdf-star=false, max-name-table-size=8, max-prefix-table-size=0, max-datatype-table-size=0." ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we put all stream options in the comments or leave it all to stream_options.jelly? Initially, it was done mostly for me so that I would not forget what I used, but it does not make much sense to duplicate this info as it is taken from the stream options file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can choose whatever way makes most sense to you. I just copy-pasted what you wrote. Feel free to change this later.

Ostrzyciel and others added 2 commits May 5, 2025 13:36
Co-authored-by: Anastasiya Danilenka <41057639+adanilenka@users.noreply.github.com>
Co-authored-by: Anastasiya Danilenka <41057639+adanilenka@users.noreply.github.com>

# Instances -- requirements

jellyt:requirementPhysicalTypeTriples a mf:Requirement ;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the requirements, but why are they not in the current examples?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because I forgot to commit them, that's why :D sorry. Good catch!

Is it OK now?

@adanilenka
Copy link
Collaborator

@Ostrzyciel I was thinking about a property that will accompany mf:Requirement and help distinguish between core vs supported specification functionality, e.g., generalized RDF and RDF-star are supported but not required. So marking them will help skip them, what do you think?

@Ostrzyciel
Copy link
Member Author

@Ostrzyciel I was thinking about a property that will accompany mf:Requirement and help distinguish between core vs supported specification functionality, e.g., generalized RDF and RDF-star are supported but not required. So marking them will help skip them, what do you think?

That ties into the thing mentioned here: #24

I'd say that even supporting the TRIPLES type is optional. Everything mentioned under requirements is. If you want to write a producer that only supports writing quads because that's your use case -- fine.

These requirement annotations will allow implementations to skip the parts that they chose to not implement. Then we can mark those cases as "unsupported" instead of "failed" in test case reports.

Makes sense?

@adanilenka
Copy link
Collaborator

adanilenka commented May 5, 2025

yes, sounds good, thank you for this clarification

@Ostrzyciel Ostrzyciel merged commit 15f29d8 into main May 5, 2025
10 checks passed
@Ostrzyciel Ostrzyciel deleted the test-case-vocab branch May 5, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants