Skip to content

More test cases for producer (to-jelly)#56

Merged
Ostrzyciel merged 7 commits intomainfrom
test-cases-producer-2
Apr 22, 2025
Merged

More test cases for producer (to-jelly)#56
Ostrzyciel merged 7 commits intomainfrom
test-cases-producer-2

Conversation

@adanilenka
Copy link
Collaborator

@adanilenka adanilenka commented Apr 22, 2025

Issue #39

New tests for:

  • UTF-8 encoding
  • literal term equality
  • repeated terms
  • frames
  • enforcement of (il)legal stream options

For pos_011, three .nt files are provided to be treated as three stream frames accordingly. out.jelly already has three expected frames inside. More "framed" cases are coming to the consumer test set.

Please note that pos_013 repeats triples in s, p, o at the same time (!), so the whole triple is repeated twice, which is not strictly described in the specification, but is a valid positive use case, I believe.

@adanilenka adanilenka requested a review from Ostrzyciel April 22, 2025 14:50
@adanilenka
Copy link
Collaborator Author

Also, please note that repeated terms are not tracked across frames on the producer side according to the specification https://jelly-rdf.github.io/dev/specification/serialization/#repeated-terms

I feel like maybe it should be somehow again stressed in the tests manifest?

adanilenka and others added 4 commits April 22, 2025 17:06
Co-authored-by: Piotr Sowiński <ostrzycielnozyczek@gmail.com>
Co-authored-by: Piotr Sowiński <ostrzycielnozyczek@gmail.com>
@adanilenka adanilenka requested a review from Ostrzyciel April 22, 2025 15:30
@Ostrzyciel Ostrzyciel merged commit 3a735a7 into main Apr 22, 2025
10 checks passed
@Ostrzyciel Ostrzyciel deleted the test-cases-producer-2 branch April 22, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants