Add the set of tests for producer with N-triples following RDF 1.1#55
Merged
Ostrzyciel merged 2 commits intomainfrom Apr 16, 2025
Merged
Add the set of tests for producer with N-triples following RDF 1.1#55Ostrzyciel merged 2 commits intomainfrom
Ostrzyciel merged 2 commits intomainfrom
Conversation
Ostrzyciel
requested changes
Apr 16, 2025
Member
Ostrzyciel
left a comment
There was a problem hiding this comment.
- Please confirm that you wrote those test cases by yourself, only being inspired by the spec. We can't have copy-paste here, it'd violate the licensing thingy.
- I'd suggest to keep to the same naming convention of RDF files as in from_jelly tests. So, instead of
in.nt, havein_001.nt. The reason is that we want cases for multiple input frames (please add such cases in follow-up PRs). - I would still include out.jelly as reference. This will be useful later for validation, because the jelly stream could be used as the comparison. This would be esp. important when we have multiple input files. Better have one file to compare to, rather than a dozen.
- Follow-up PRs: please add test cases checking if UTF-8 strings are supported, not just ASCII, because the Jelly spec says so.
Collaborator
Author
|
by inspired, I meant the part of the RDF 1.1 under test, not specific triples/file content, e.g., "blank node as a subject", so it is more about what must be considered in the test cases the insides of .nt files are just example.org abstract stuff |
Member
perfect, thank you. Needed to make sure for legal reasons. Please forgive me. 🙇 |
Ostrzyciel
approved these changes
Apr 16, 2025
Member
|
Issue: #39 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test set draws from https://www.w3.org/2013/N-TriplesTests/
But focuses only on core things that make sense in the encoding: terms, datatypes, string literals.
Initially, there was also a test with comments, but as comments are not mentioned in the rdf 1.1, the test was omitted.