Only perform recursion depth checks on recursive messages#553
Merged
Karolina-Bogacka merged 2 commits intomainfrom Sep 28, 2025
Merged
Only perform recursion depth checks on recursive messages#553Karolina-Bogacka merged 2 commits intomainfrom
Karolina-Bogacka merged 2 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Karolina-Bogacka
approved these changes
Sep 28, 2025
Collaborator
Karolina-Bogacka
left a comment
There was a problem hiding this comment.
The tests seem sufficient and the changes make sense
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A truly micro optimization.
We were checking the recursion depth already quite efficiently, but we can do a little bit better with the observation that most messages are, in fact, not recursive. For them it's enough to just increment the depth.
If we remove the check on everything aside from RdfTriple, our security will not be compromised (as proven by tests). During inlining, the compiler should also get rid of this parameter entirely in some code paths.