RDF4J: implement a full checking parser#546
Merged
Ostrzyciel merged 1 commit intomainfrom Sep 27, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
Karolina-Bogacka
approved these changes
Sep 27, 2025
Collaborator
Karolina-Bogacka
left a comment
There was a problem hiding this comment.
Looks good and the tests seem sufficient to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing eclipse-rdf4j/rdf4j#5449 I noticed that the Jelly parser ignores various optional checks that you can add to every RDF4J parser, such as
SKOLEMIZE_ORIGINorVERIFY_DATATYPE_VALUES. This is because we use decoder converters, which can work outside an RDF4J parser, and therefore use a value factory directly, without any extra checks. To run these checks, you have to use the protectedcreate*methods inAbstractRDFParserinstead.So, to solve this I wrote a second decoder converter that is internal to the RDF4J parser, where it uses these
create*methods as RDF4J intended. This can be still turned off by passing a different decoder converter, or by setting theCHECKINGoption to false.Note that this is a default behavior change, as
JellyParserFactory.getParser()will now return a checking parser, instead of a non-checking one. But I don't think that violates any specific contract... the extra checks are disabled by default anyway.