Skip to content

Fix neo4j plugin initialization#512

Merged
Ostrzyciel merged 1 commit intomainfrom
piotr/fix-neo4j-plugin-init
Aug 26, 2025
Merged

Fix neo4j plugin initialization#512
Ostrzyciel merged 1 commit intomainfrom
piotr/fix-neo4j-plugin-init

Conversation

@Ostrzyciel
Copy link
Member

Previously it only worked after a call to jelly.version(). This is not great, so I added a small hack to get the plugin initialized earlier. Unfortunately I don't have a better idea because neither Neo4j nor Neosemantics provide APIs that could help with this.

Previously it only worked after a call to `jelly.version()`. This is not great, so I added a small hack to get the plugin initialized earlier. Unfortunately I don't have a better idea because neither Neo4j nor Neosemantics provide APIs that could help with this.
@codecov
Copy link

codecov bot commented Aug 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ Complexity Δ
...k/jelly/convert/neo4j/JellyInitializationHook.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...link/jelly/convert/neo4j/JellyTripleCollector.java 100.00% <100.00%> (ø) 3.00 <1.00> (+1.00)
...ly/convert/neo4j/rio/JellyBase64ParserFactory.java 100.00% <ø> (ø) 3.00 <0.00> (-1.00)
...ly/convert/neo4j/rio/JellyBase64WriterFactory.java 66.66% <ø> (-4.77%) 4.00 <0.00> (-1.00)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Ostrzyciel Ostrzyciel enabled auto-merge (squash) August 26, 2025 18:41
Copy link
Collaborator

@Karolina-Bogacka Karolina-Bogacka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the greatest fan of the hack, but it's definitely better than having to explicitely call jelly.version()

@Ostrzyciel Ostrzyciel merged commit 83e305a into main Aug 26, 2025
11 of 12 checks passed
@Ostrzyciel Ostrzyciel deleted the piotr/fix-neo4j-plugin-init branch August 26, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants