Initial implementation with context parameters#162
Merged
Ostrzyciel merged 4 commits intomainfrom Jul 16, 2025
Merged
Conversation
Ostrzyciel
requested changes
Jul 16, 2025
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/MetricsPrinter.scala
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #74
Everything came together really nicely with context parameters.
One thing is that I'm not sure how accurate the statistics are. I use getSerializedSize() of ProtoMessage as the source (and length of encoded string + 1 for the tag byte), but I'm not sure if these are correct.
I was hoping that triples_size would equal subject_size + predicate_size + object_size, but that isn't the case.