Add detailed content reporting for rdf inspect#159
Merged
niegrzybkowski merged 15 commits intomainfrom Jul 16, 2025
Merged
Conversation
This reverts commit 5efea83.
Ostrzyciel
requested changes
Jul 15, 2025
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfInspect.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfInspect.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfInspect.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/MetricsPrinter.scala
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/MetricsPrinter.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/MetricsPrinter.scala
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/MetricsPrinter.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/MetricsPrinter.scala
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I will refactor FrameInfo stuff later (when working on #74 ), for now I left it as-is |
Ostrzyciel
requested changes
Jul 16, 2025
Member
Ostrzyciel
left a comment
There was a problem hiding this comment.
minor comments, I'll now download it and try running it ;)
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfInspect.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfInspect.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/MetricsPrinter.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Piotr Sowiński <ostrzycielnozyczek@gmail.com>
Ostrzyciel
requested changes
Jul 16, 2025
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/MetricsPrinter.scala
Outdated
Show resolved
Hide resolved
src/main/scala/eu/neverblink/jelly/cli/command/rdf/RdfInspect.scala
Outdated
Show resolved
Hide resolved
Ostrzyciel
reviewed
Jul 16, 2025
src/main/scala/eu/neverblink/jelly/cli/command/rdf/util/MetricsPrinter.scala
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #75
This PR adds a
--detailoption, which when set will generate a detailed report on the counts of different terms and nodes, grouped depending on the (one offlat,node,term).nodewill group by node types, i.e.iri,bnodetermwill group by term types i.e.subject,predicateflatwill not reduce the counts, instead concatenating field names, i.e.subject_iri_countI move some functionality inside FrameInfo in preparation, and I create a subclass FrameDetailInfo, which holds the detail information and the functionality necessary to aggregate the details appropriately.
I also convert MetricsPrinter to a class, as I needed to handle formatting grouping in different ways, I do it by passing the formatter as a constructor argument.