Add updating existing open issue with the same title if it exists#71
Add updating existing open issue with the same title if it exists#71JasonEtco merged 25 commits intoJasonEtco:masterfrom PrinsFrank:feature-update-existing-issue-when-present
Conversation
JasonEtco
left a comment
There was a problem hiding this comment.
This is awesome @PrinsFrank 😱 ❤️
I left a couple of notes for improvements. As for testing, you have two options - either writing unit tests here and seeing that they pass (which we need to do anyway), or using your forked action. It doesn't need to be published to Marketplace; you can just do:
uses: PrinsFrank/create-an-issue@feature-update-existing-issue-when-present|
I think I have everything running correctly, and will continue tomorrow with writing tests. |
JasonEtco
left a comment
There was a problem hiding this comment.
This looks great @PrinsFrank ✨ The tests are perfect, the implementation is 🔥. Thank you for all your work on it so far!
I left a couple of very minor comments, the one in the search query is needed to make sure we're finding the right issue titles. Let me know if I can clarify anything! I think after these this should be good to go 🚀
|
@JasonEtco, do you have any time to review this? |
|
Hello, I would be interested by this feature ! (Awesome work by the way). I could implement #55 when this issue will be merged. |
JasonEtco
left a comment
There was a problem hiding this comment.
This looks great to me, sorry it took so long for me to come back to re-review it! Thanks for your work on this, especially the tests and docs 🙌
Hey @JasonEtco, I tried to implement #63 , but I'm a bit out of my depth here as I'm not familiar with developing actions. How can I test these changes without publishing my fork on the marketplace?