Skip to content

Add support for env variables#52

Closed
sunt05 wants to merge 0 commit intoJasonEtco:masterfrom
sunt05:master
Closed

Add support for env variables#52
sunt05 wants to merge 0 commit intoJasonEtco:masterfrom
sunt05:master

Conversation

@sunt05
Copy link
Copy Markdown
Contributor

@sunt05 sunt05 commented Apr 3, 2020

A PR to resolve #51 .

@sunt05
Copy link
Copy Markdown
Contributor Author

sunt05 commented Apr 3, 2020

Hi @JasonEtco , I followed your suggestion to add this support.
However, I'm very inexperienced in JS and might not be able to add proper test for this; could you help with that?
Thanks!

@JasonEtco
Copy link
Copy Markdown
Owner

I messed up @sunt05 😅 I accidentally overwrote your changes. Will have a proper PR together shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

use env variables

2 participants