Merged
Conversation
`@tsconfig/node12` → `@tsconfig/node-lts`
An upstream bug is preventing us from using @tsconfig/node-lts, so we'll use @tsconfig/recommended for now.
JasonEtco
approved these changes
Feb 15, 2024
Owner
JasonEtco
left a comment
There was a problem hiding this comment.
Thanks @parkerbxyz! You're the best ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request primarily focuses on upgrading the Node.js version used across different parts of the codebase to version 20. The changes affect the continuous integration pipeline, the action configuration, and the development dependencies.
Node.js version upgrade:
action.yml: The Node.js version used in the action configuration has been updated from node16 to node20. This change will affect the environment in which the GitHub action runs..github/workflows/ci.yml: The Node.js version used in the continuous integration pipeline has been updated from 18.x to 20.x. This change will affect the environment in which the CI jobs are run.package.json: The Node.js version specified in the development dependencies has been updated from@tsconfig/node12to@tsconfig/node20. This change will affect the environment in which the development and testing tasks are run.This will resolve #175 and the following warning that is currently produced when this action is used in a workflow:
Warning
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: e27dddc. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.