Added search_existing param.#111
Merged
JasonEtco merged 6 commits intoJasonEtco:mainfrom Sep 28, 2021
Merged
Conversation
JasonEtco
reviewed
Sep 27, 2021
Owner
JasonEtco
left a comment
There was a problem hiding this comment.
This is fine with me 👍 This Action is getting a little more complex than initially intended though 😆 Thanks for adding tests and README docs 🙏
I left a note about simplifying the number of API calls we're making, to just use one query for both open and closed issues. Let me know if that makes sense.
The `search_existing` param lets you specify whether to search open and/or closed existing issues for duplicates (default is `open`).
8bd256d to
bee3c89
Compare
JasonEtco
approved these changes
Sep 28, 2021
Owner
JasonEtco
left a comment
There was a problem hiding this comment.
Looks great! I made a couple minor adjustments to docs/tests after updating from main. Thanks for doing this 🙌
Owner
|
Published in https://github.com/JasonEtco/create-an-issue/releases/tag/v2.6.0! Thanks again for the contribution 🙌 |
1 task
This was referenced Oct 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
search_existingparam lets you specify whether to search open and/or closed existing issues for duplicates (default isopen).Closes #109