Extension not needed anymore + Tests#370
Closed
alexander-schranz wants to merge 22 commits intoJan0707:masterfrom
Closed
Extension not needed anymore + Tests#370alexander-schranz wants to merge 22 commits intoJan0707:masterfrom
alexander-schranz wants to merge 22 commits intoJan0707:masterfrom
Conversation
Conflicts: composer.lock
310ea24 to
03fea02
Compare
Contributor
|
I suggest cleaning the history, to avoid adding stubs and removing them again in the same PR... |
Contributor
|
And the commit message and PR title should probably talk about "return type extension" instead of "extension" (the whole package is a phpstan extension after all, and that extension is still needed as it uses more kind of extension points) |
Collaborator
Author
|
@stof will wait for the phpstan release and then create a clean PR. |
Contributor
|
PHPStan 2.1.5 is out https://github.com/phpstan/phpstan/releases/tag/2.1.5 |
Collaborator
Author
|
replaced by: #369 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tests adjustments of @ondrejmirtes in #369
Against the new tests in #366