Increase CI matrix to test against more recent PHPUnit & PHP versions#351
Merged
alexander-schranz merged 4 commits intoJan0707:masterfrom Nov 21, 2024
Merged
Increase CI matrix to test against more recent PHPUnit & PHP versions#351alexander-schranz merged 4 commits intoJan0707:masterfrom
alexander-schranz merged 4 commits intoJan0707:masterfrom
Conversation
Contributor
Author
|
SA failure is due to the fact that we're using The same failure does not happen in the CI job with PHPUnit 9.6.0, since it allows v5 since I fixed it by running |
alexander-schranz
approved these changes
Nov 21, 2024
Contributor
Author
@Jan0707 I did this in the last commit, let me know if it's ok or if I should drop it. |
Contributor
Author
|
Sorry, I needed to ping you @alexander-schranz 😓 |
Collaborator
|
Fine with the using ramsey github action. |
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #348, and tries to add more configuration to test.
Let me know if you want me to follow some specific approach, for now I'm trying a balance between testing all the versions and not having too many jobs to execute.
@Jan0707 WDYT about dropping the custom actions for Composer and migrati to
ramsey/composer-install? It has all in one, caching included.