Allow PHPUnit 10 & 11#334
Merged
alexander-schranz merged 2 commits intoJan0707:masterfrom Apr 3, 2024
Merged
Conversation
Collaborator
|
yeah PHPUnit 10 and 11 was currently not official suppored or tested. The conflict was written false which did allow still the installation. But fine to open the version constraint if you didn't have any problems with it. Thx for the PR. |
Contributor
Author
|
Thank you for the quick merge! I would advise to change the CI though, because you're not testing with 10 and 11 in any case here, and you also need to test with the prophecy-phpunit trait too then. |
|
It seems that this update is not yet included in any tag, when will this happen? Many thanks in advance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request
Related to #332.
I started getting CI failures since 1.0.1 due to the inclusion of #332; before, the
conflictrule was broken and allowed me to use this package happily with PHPUnit 10 and 11: https://github.com/facile-it/paraunit/actions/runs/8432471574/job/23091610492#step:4:109