allow nested paths in target-folder + add attempt-limit parameter#1737
Merged
JamesIves merged 3 commits intoJamesIves:devfrom Nov 24, 2024
Merged
allow nested paths in target-folder + add attempt-limit parameter#1737JamesIves merged 3 commits intoJamesIves:devfrom
target-folder + add attempt-limit parameter#1737JamesIves merged 3 commits intoJamesIves:devfrom
Conversation
target-folder + add attempt-limit parameter
JamesIves
reviewed
Nov 20, 2024
Owner
JamesIves
left a comment
There was a problem hiding this comment.
Changes look good to me, appreciate the contribution. Left a comment but I can work on merging this later this week.
JamesIves
approved these changes
Nov 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #1737 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 7 7
Lines 310 310
Branches 85 86 +1
=======================================
Hits 290 290
Misses 18 18
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--mkpathflag to the rsync command to allow it to make missing directories. This is useful when many different pages are being deployed, so a deeply nested descriptive path can be specified intarget-folder. Right now, doing so leads to an error in rsync complaining about missing directories.attempt-limitparameter to allow more rebase/push attempts than the default of 3. This is useful when many different actions are racing to deploy many different pages.Testing
I built this code (databasedav@ec82a36) and used it (https://github.com/databasedav/haalka/blob/18a199464edc9cf3eb3e04989b30893f970097f0/.github/workflows/preview_deploy.yaml#L21) in this PR databasedav/haalka#6. Note that the
target-folderis a deeply nested path https://github.com/databasedav/haalka/pull/6/files#diff-05da7bfe214f8a02b4727e2f5970ac5b86684f522864a6917da71a3efa04ba13R27 and pushing is attempted more than 3 times https://github.com/databasedav/haalka/actions/runs/11870171025/job/33082157315#step:5:257.One can see a deployed page here https://databasedav.github.io/haalka/pr_previews/6/webgpu/button/, note it requires a webgpu compatible browser (e.g. chrome, firefox nightly, not firefox stable) to work.