Add encoding option#480
Merged
JamesIves merged 1 commit intoJamesIves:devfrom Jan 12, 2022
humble-barnacle001:dev
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #480 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 89 87 -2
Branches 23 22 -1
=========================================
- Hits 89 87 -2
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #468 in #468 (comment)
Added a new option:
encodingwhich allows to specify the encoding of the file in which data fetched is saved.Testing Instructions
yarn testAdditional Notes
BufferEncodingit should throw an error.