Skip to content
This repository was archived by the owner on Aug 14, 2025. It is now read-only.

Spotless + Ktlint + Compose rules#90

Merged
JakeWharton merged 4 commits into
JakeWharton:trunkfrom
Goooler:trunk
Jan 24, 2024
Merged

Spotless + Ktlint + Compose rules#90
JakeWharton merged 4 commits into
JakeWharton:trunkfrom
Goooler:trunk

Conversation

@Goooler

@Goooler Goooler commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@Goooler

Goooler commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

Introduce org.jetbrains.kotlinx:kotlinx-collections-immutable to fit https://mrmans0n.github.io/compose-rules/rules/#use-immutable-annotation-whenever-possible

OLD: before.apk (signature: V2)
NEW: after.apk (signature: V2)

          │           compressed            │          uncompressed
          ├──────────┬──────────┬───────────┼──────────┬──────────┬───────────
 APK      │ old      │ new      │ diff      │ old      │ new      │ diff
──────────┼──────────┼──────────┼───────────┼──────────┼──────────┼───────────
      dex │  2.2 MiB │  2.2 MiB │ +13.7 KiB │  2.2 MiB │  2.2 MiB │ +13.7 KiB
     arsc │ 21.1 KiB │ 21.1 KiB │       0 B │   21 KiB │   21 KiB │       0 B
 manifest │  2.9 KiB │  2.9 KiB │       0 B │ 12.9 KiB │ 12.9 KiB │       0 B
      res │ 12.9 KiB │ 12.9 KiB │       0 B │  8.5 KiB │  8.5 KiB │       0 B
    asset │  3.2 KiB │  2.7 KiB │    -543 B │  2.9 KiB │  2.4 KiB │    -539 B
    other │ 41.4 KiB │ 41.4 KiB │       0 B │ 40.6 KiB │ 40.6 KiB │       0 B
──────────┼──────────┼──────────┼───────────┼──────────┼──────────┼───────────
    total │  2.2 MiB │  2.3 MiB │ +13.2 KiB │  2.3 MiB │  2.3 MiB │ +13.2 KiB


 DEX     │ old   │ new   │ diff
─────────┼───────┼───────┼─────────────────
   files │     1 │     1 │   0
 strings │ 17115 │ 17157 │ +42 (+55 -13)
   types │  3671 │  3683 │ +12 (+21 -9)
 classes │  2950 │  2962 │ +12 (+21 -9)
 methods │ 14174 │ 14272 │ +98 (+414 -316)
  fields │  8491 │  8525 │ +34 (+111 -77)


 ARSC    │ old │ new │ diff
─────────┼─────┼─────┼──────
 configs │  19 │  19 │  0
 entries │ 260 │ 260 │  0


=================
====   APK   ====
=================

     compressed      │    uncompressed     │
─────────┬───────────┼─────────┬───────────┤
 size    │ diff      │ size    │ diff      │ path
─────────┼───────────┼─────────┼───────────┼────────────────────────────────
 2.2 MiB │ +13.7 KiB │ 2.2 MiB │ +13.7 KiB │ ∆ classes.dex
 2.3 KiB │    -542 B │ 2.1 KiB │    -542 B │ ∆ assets/dexopt/baseline.prof
   401 B │      -1 B │   267 B │      +3 B │ ∆ assets/dexopt/baseline.profm
─────────┼───────────┼─────────┼───────────┼────────────────────────────────
 2.2 MiB │ +13.2 KiB │ 2.2 MiB │ +13.2 KiB │ (total)

=================
====   DEX   ====
=================

TYPES:

   old  │ new  │ diff
  ──────┼──────┼──────────────
   3671 │ 3683 │ +12 (+21 -9)

  + Landroidx/activity/compose/BackHandlerKt$BackHandler$3;
  + Landroidx/compose/ui/layout/RootMeasurePolicy$measure$4;
  + Landroidx/room/AutoCloser$Companion;
  + Lcom/jakewharton/sa4p/presenter/MainPresenterKt$mainPresenter$1$1;
  + Lcom/jakewharton/sa4p/presenter/MainPresenterKt$mainPresenter$3$1;
  + Lcom/jakewharton/sa4p/presenter/MainPresenterKt$mainPresenter$3;
  + Lcom/jakewharton/sa4p/ui/PendingUrlsKt$PendingUrls$2;
  + Lkotlinx/collections/immutable/ImmutableList$SubList;
  + Lkotlinx/collections/immutable/ImmutableList;
  + Lkotlinx/collections/immutable/PersistentList$Builder;
  + Lkotlinx/collections/immutable/PersistentList;
  + Lkotlinx/collections/immutable/implementations/immutableList/AbstractListIterator;
  + Lkotlinx/collections/immutable/implementations/immutableList/AbstractPersistentList;
  + Lkotlinx/collections/immutable/implementations/immutableList/BufferIterator;
  + Lkotlinx/collections/immutable/implementations/immutableList/PersistentVector;
  + Lkotlinx/collections/immutable/implementations/immutableList/PersistentVectorBuilder;
  + Lkotlinx/collections/immutable/implementations/immutableList/PersistentVectorIterator;
  + Lkotlinx/collections/immutable/implementations/immutableList/PersistentVectorMutableIterator;
  + Lkotlinx/collections/immutable/implementations/immutableList/SmallPersistentVector;
  + Lkotlinx/collections/immutable/implementations/immutableList/TrieIterator;
  + Lokio/Utf8;

  - Landroidx/compose/foundation/lazy/LazyListItemProviderImpl$Item$2;
  - Landroidx/compose/runtime/external/kotlinx/collections/immutable/implementations/immutableList/AbstractListIterator;
  - Landroidx/core/view/accessibility/AccessibilityNodeProviderCompat;
  - Landroidx/work/SystemClock;
  - Lcom/jakewharton/sa4p/presenter/MainPresenterKt$MainPresenter$1$1;
  - Lcom/jakewharton/sa4p/presenter/MainPresenterKt$MainPresenter$3$1;
  - Lcom/jakewharton/sa4p/presenter/MainPresenterKt$MainPresenter$3;
  - Lcom/jakewharton/sa4p/ui/PendingUrlsKt$PendingUrls$1;
  - Lokio/ByteString$Companion;

@JakeWharton JakeWharton left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, just need to hook up the modifiers where added.

Comment thread app/src/main/kotlin/com/jakewharton/sa4p/ui/MainUi.kt Outdated
Comment thread app/src/main/kotlin/com/jakewharton/sa4p/ui/MainUi.kt
Comment thread app/src/main/kotlin/com/jakewharton/sa4p/ui/footer.kt
Comment thread app/src/main/kotlin/com/jakewharton/sa4p/ui/pendingUrls.kt
Comment thread app/src/main/kotlin/com/jakewharton/sa4p/ui/theme.kt Outdated
Comment thread app/src/main/kotlin/com/jakewharton/sa4p/ui/footer.kt Outdated
Goooler and others added 2 commits January 25, 2024 00:21
Co-authored-by: Jake Wharton <github@jakewharton.com>
@JakeWharton JakeWharton enabled auto-merge (squash) January 24, 2024 16:42
@JakeWharton JakeWharton merged commit 825e0c8 into JakeWharton:trunk Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants